Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinct aggregate over node and relationships #3236

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

andyfengHKU
Copy link
Contributor

This PR add support to distinct aggregate over nodes and relationships.

On the side, it refactors some of the legacy naming or inappropriate usage of smart pointers.

Note that I start using an additional wrapper on top of ku_dynamic_cast in this PR. See

    template<class TARGET>
    const TARGET* safePtrCast() const {
        return common::ku_dynamic_cast<const Expression*, const TARGET*>(this);
    }
    template<class TARGET>
    TARGET* unsafePtrCast() {
        return common::ku_dynamic_cast<Expression*, TARGET*>(this);
    }

@benjaminwinger and @ray6080 should comment regarding this wrapper.

@andyfengHKU andyfengHKU requested a review from ray6080 April 8, 2024 22:32
@ray6080 ray6080 merged commit a7c183d into master Apr 9, 2024
18 checks passed
@ray6080 ray6080 deleted the distinct-agg-node branch April 9, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants