-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coalesce function #3235
Merged
Merged
Add coalesce function #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
requested changes
Apr 9, 2024
manh9203
force-pushed
the
add-coalesce-function
branch
from
April 10, 2024 20:41
675bf6f
to
3647964
Compare
andyfengHKU
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to take another look for selectFunc and some additional testing.
manh9203
force-pushed
the
add-coalesce-function
branch
from
April 15, 2024 16:32
3647964
to
25d12a0
Compare
manh9203
force-pushed
the
add-coalesce-function
branch
from
April 22, 2024 16:37
25d12a0
to
65bb3db
Compare
manh9203
force-pushed
the
add-coalesce-function
branch
from
April 24, 2024 16:33
65bb3db
to
568c450
Compare
andyfengHKU
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added coalesce and ifnull functions.