Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coalesce function #3235

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Add coalesce function #3235

merged 6 commits into from
Apr 24, 2024

Conversation

manh9203
Copy link
Contributor

@manh9203 manh9203 commented Apr 8, 2024

This PR added coalesce and ifnull functions.

src/function/utility/coalesce.cpp Outdated Show resolved Hide resolved
test/test_files/function/hash/utility/coalesce.test Outdated Show resolved Hide resolved
src/function/utility/coalesce.cpp Outdated Show resolved Hide resolved
src/function/utility/coalesce.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to take another look for selectFunc and some additional testing.

src/function/utility/coalesce.cpp Outdated Show resolved Hide resolved
src/function/utility/coalesce.cpp Outdated Show resolved Hide resolved
src/function/utility/coalesce.cpp Show resolved Hide resolved
src/function/utility/coalesce.cpp Outdated Show resolved Hide resolved
src/function/utility/coalesce.cpp Outdated Show resolved Hide resolved
src/function/utility/coalesce.cpp Outdated Show resolved Hide resolved
test/test_files/function/hash/utility/coalesce.test Outdated Show resolved Hide resolved
@manh9203 manh9203 requested review from andyfengHKU and removed request for andyfengHKU April 24, 2024 17:36
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manh9203 manh9203 merged commit 9253e97 into master Apr 24, 2024
17 checks passed
@manh9203 manh9203 deleted the add-coalesce-function branch April 24, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants