Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE_CXX_FLAGS handling fails when variable is empty #3228

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

zaddach
Copy link
Contributor

@zaddach zaddach commented Apr 6, 2024

Fixes #3227

@ray6080
Copy link
Contributor

ray6080 commented Apr 7, 2024

Hi @zaddach , thanks for your fix!
Could you please take a look at our CLA and add “I have read and agree to the terms under CLA.md” to your PR description if you agree with the CLA?

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (d946982) to head (c7fb5a2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3228      +/-   ##
==========================================
- Coverage   92.28%   92.27%   -0.01%     
==========================================
  Files        1161     1161              
  Lines       44150    44150              
==========================================
- Hits        40744    40740       -4     
- Misses       3406     3410       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaddach
Copy link
Contributor Author

zaddach commented Apr 7, 2024

I have read and agree to the terms under CLA.md

@ray6080 ray6080 merged commit 8006723 into kuzudb:master Apr 7, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMAKE_CXX_FLAGS handling fails when empty string
2 participants