-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DATE TO DATE and TIMESTAMP TO DATE casting functions. #3220
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3220 +/- ##
==========================================
- Coverage 92.28% 92.28% -0.01%
==========================================
Files 1161 1161
Lines 44150 43926 -224
==========================================
- Hits 40744 40536 -208
+ Misses 3406 3390 -16 ☔ View full report in Codecov by Sentry. |
note: in copying the ValueVector in resolving nested types, an assert for |
Closes #3218
DATE TO DATE casting is called when casting nested datatypes, eg LISTS and STRUCTS, and so registering it is necessary. See the linked issue for an example.
TIMESTAMP to DATE casting uses
Timestamp::getDate
.