Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List offset Column Refactor #3219

Merged
merged 2 commits into from
Apr 8, 2024
Merged

List offset Column Refactor #3219

merged 2 commits into from
Apr 8, 2024

Conversation

hououou
Copy link
Collaborator

@hououou hououou commented Apr 5, 2024

see #3093

As we discussed, we should try not to implement offset column chunk/column. So, I refactor only the prepare commit for the offset column.

The writing performance has improved. See the following picture.

image

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (d946982) to head (16c5d1b).
Report is 3 commits behind head on master.

❗ Current head 16c5d1b differs from pull request most recent head ad1d859. Consider uploading reports for the commit ad1d859 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files        1161     1161              
  Lines       44150    44168      +18     
==========================================
+ Hits        40744    40759      +15     
- Misses       3406     3409       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hououou hououou requested a review from ray6080 April 6, 2024 04:51
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can you close #3198 when you merge this one?

src/include/storage/store/list_column.h Outdated Show resolved Hide resolved
src/include/storage/store/list_column.h Outdated Show resolved Hide resolved
src/include/storage/store/list_column.h Outdated Show resolved Hide resolved
src/storage/store/list_column.cpp Outdated Show resolved Hide resolved
@hououou hououou merged commit c6e62e9 into master Apr 8, 2024
@hououou hououou deleted the list_offset branch April 8, 2024 06:05
@andyfengHKU andyfengHKU mentioned this pull request Apr 15, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants