Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyarrow segfaulting on fedora 39 #3213

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

mxwli
Copy link
Collaborator

@mxwli mxwli commented Apr 4, 2024

Closes #3202

@mxwli mxwli requested a review from acquamarin April 4, 2024 20:45
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (37de692) to head (76fae68).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
+ Coverage   92.26%   92.27%   +0.01%     
==========================================
  Files        1161     1161              
  Lines       44145    44145              
==========================================
+ Hits        40729    40735       +6     
+ Misses       3416     3410       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a short description about what is the bug and why it appears and how you are solving it?

@mxwli
Copy link
Collaborator Author

mxwli commented Apr 5, 2024

There are two possible causes of the bug, both of which have been fixed:

  1. auto pyTableName = py::str(objectName);, when run without a GIL can cause a segfault.
  2. py::reinterpret_borrow still manages the refcount, so I've elected to not hold a reference to the dataframe inside PyArrowTableScanFunctionData anymore.

@mxwli mxwli merged commit 33111c8 into master Apr 5, 2024
35 checks passed
@mxwli mxwli deleted the pandas-pyarrow-backend branch April 5, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python test fails with SEGFAULT on Fedora 39
2 participants