Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility hash functions #3212

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add utility hash functions #3212

merged 2 commits into from
Apr 8, 2024

Conversation

manh9203
Copy link
Collaborator

@manh9203 manh9203 commented Apr 4, 2024

This PR added these utility hash functions:

@manh9203 manh9203 requested a review from acquamarin April 4, 2024 19:52
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 86.41975% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 92.26%. Comparing base (d946982) to head (2f898b9).
Report is 6 commits behind head on master.

❗ Current head 2f898b9 differs from pull request most recent head c5e7e8e. Consider uploading reports for the commit c5e7e8e to get more accurate results

Files Patch % Lines
src/function/vector_hash_functions.cpp 87.75% 6 Missing ⚠️
src/common/sha256.cpp 77.27% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3212      +/-   ##
==========================================
- Coverage   92.28%   92.26%   -0.02%     
==========================================
  Files        1161     1163       +2     
  Lines       44150    44197      +47     
==========================================
+ Hits        40744    40780      +36     
- Misses       3406     3417      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to double check how you are changing the mbedtls.

CMakeLists.txt Show resolved Hide resolved
src/common/sha256.cpp Show resolved Hide resolved
src/include/function/hash/functions/md5_function.h Outdated Show resolved Hide resolved
src/include/function/hash/functions/sha256_function.h Outdated Show resolved Hide resolved
@manh9203 manh9203 requested a review from acquamarin April 5, 2024 19:09
Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manh9203 manh9203 merged commit e720f7f into master Apr 8, 2024
@manh9203 manh9203 deleted the utility-hash-functions branch April 8, 2024 16:27
@prrao87 prrao87 mentioned this pull request May 1, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants