-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework comment on operator & support show_macros function #3205
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3205 +/- ##
==========================================
- Coverage 92.28% 92.16% -0.13%
==========================================
Files 1161 1151 -10
Lines 44150 44117 -33
==========================================
- Hits 40744 40659 -85
- Misses 3406 3458 +52 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't finished review on transaction part. will continue later. but I feel you should wait for my PR (#3204) to be merged, which refactored how wal is serialized.
98576b5
to
6e54fa5
Compare
@hououou can you do a rebase? I can review after rebasing. |
a8cab78
to
9630e16
Compare
This is stale now. See #3656. |
see #3179