Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework comment on operator & support show_macros function #3205

Closed
wants to merge 3 commits into from

Conversation

hououou
Copy link
Collaborator

@hououou hououou commented Apr 3, 2024

see #3179

@hououou hououou requested a review from acquamarin April 3, 2024 19:37
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 76.17021% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 92.16%. Comparing base (d946982) to head (98576b5).
Report is 11 commits behind head on master.

❗ Current head 98576b5 differs from pull request most recent head 51a0e55. Consider uploading reports for the commit 51a0e55 to get more accurate results

Files Patch % Lines
src/storage/wal/wal_record.cpp 52.56% 37 Missing ⚠️
src/storage/wal_replayer.cpp 43.47% 13 Missing ⚠️
src/include/storage/wal/wal_record.h 66.66% 4 Missing ⚠️
src/catalog/catalog.cpp 95.65% 1 Missing ⚠️
src/function/table/call/show_macros.cpp 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3205      +/-   ##
==========================================
- Coverage   92.28%   92.16%   -0.13%     
==========================================
  Files        1161     1151      -10     
  Lines       44150    44117      -33     
==========================================
- Hits        40744    40659      -85     
- Misses       3406     3458      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished review on transaction part. will continue later. but I feel you should wait for my PR (#3204) to be merged, which refactored how wal is serialized.

src/binder/bind/bind_comment_on.cpp Outdated Show resolved Hide resolved
src/include/catalog/catalog.h Outdated Show resolved Hide resolved
src/include/catalog/catalog_entry/catalog_entry_type.h Outdated Show resolved Hide resolved
src/include/parser/comment_on.h Outdated Show resolved Hide resolved
src/include/binder/ddl/bound_alter_info.h Outdated Show resolved Hide resolved
@ray6080
Copy link
Contributor

ray6080 commented Apr 9, 2024

@hououou can you do a rebase? I can review after rebasing.

@ray6080
Copy link
Contributor

ray6080 commented Jun 17, 2024

This is stale now. See #3656.

@ray6080 ray6080 closed this Jun 17, 2024
@ray6080 ray6080 deleted the rework_comment_on branch August 22, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants