Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Physical Type ARRAY #3175

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add Physical Type ARRAY #3175

merged 1 commit into from
Apr 9, 2024

Conversation

manh9203
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (0b70b02) to head (6e00d12).

❗ Current head 6e00d12 differs from pull request most recent head 28443fd. Consider uploading reports for the commit 28443fd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3175      +/-   ##
==========================================
- Coverage   92.42%   92.19%   -0.24%     
==========================================
  Files        1164     1156       -8     
  Lines       44103    43985     -118     
==========================================
- Hits        40762    40551     -211     
- Misses       3341     3434      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/types/types.cpp Outdated Show resolved Hide resolved
src/common/types/types.cpp Outdated Show resolved Hide resolved
src/common/types/types.cpp Outdated Show resolved Hide resolved
src/common/types/types.cpp Outdated Show resolved Hide resolved
@manh9203 manh9203 changed the title (Draft) Add Physical Type ARRAY Add Physical Type ARRAY Apr 9, 2024
@manh9203 manh9203 merged commit 4451bf8 into master Apr 9, 2024
18 checks passed
@manh9203 manh9203 deleted the add-array-physical-type branch April 9, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants