Fix export database regression #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
approved these changes
Mar 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3171 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 1170 1170
Lines 44181 44182 +1
=======================================
+ Hits 40683 40684 +1
Misses 3498 3498 ☔ View full report in Codecov by Sentry. |
andyfengHKU
force-pushed
the
fix-export-database-regression
branch
from
177b503
to
17a19d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an export database regression issue.
The issue is due to we rebind in prepare & execute function call. And export directory is created in the first binding stage. This PR moves the directory creation to mapper. Ideally we should do it insider operator but it's not doable at this point because child pipelines require directory to exist first.