Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initcap/concat functions #3161

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Implement initcap/concat functions #3161

merged 2 commits into from
Mar 28, 2024

Conversation

acquamarin
Copy link
Collaborator

This PR implements the inicap and concat functions as requested by the user.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.08%. Comparing base (c747899) to head (c380ed8).
Report is 3 commits behind head on master.

Files Patch % Lines
src/function/vector_string_functions.cpp 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3161      +/-   ##
==========================================
- Coverage   92.08%   92.08%   -0.01%     
==========================================
  Files        1168     1168              
  Lines       44087    44104      +17     
==========================================
+ Hits        40598    40611      +13     
- Misses       3489     3493       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit 956b3e3 into master Mar 28, 2024
17 checks passed
@acquamarin acquamarin deleted the initcap-function branch March 28, 2024 04:33
@andyfengHKU andyfengHKU mentioned this pull request Apr 15, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants