Resolve ANY Resolution Occurring at End of Python List Parameter #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3160 +/- ##
==========================================
- Coverage 92.08% 92.08% -0.01%
==========================================
Files 1168 1168
Lines 44087 44084 -3
==========================================
- Hits 40598 40593 -5
- Misses 3489 3491 +2 ☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Mar 28, 2024
|
Fixes the additional bug brought up at #3054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1, 2, 3, None]and{'a': 1, 'b': None}should correctly resolve toINT64[]andMAP(STRING, INT64)now.Additionally,
[]resolves toANY[]instead ofSTRING[]so that[[], [1, 2, 3]]resolves toINT64[][]instead ofSTRING[][]