Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to compute hash on list of struct #3157

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Mar 27, 2024

This PR supports compute hash on list of struct.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 92.09%. Comparing base (c1f68cd) to head (219ed69).
Report is 2 commits behind head on master.

Files Patch % Lines
src/function/vector_hash_functions.cpp 93.87% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
+ Coverage   91.95%   92.09%   +0.13%     
==========================================
  Files        1168     1168              
  Lines       44085    44087       +2     
==========================================
+ Hits        40538    40601      +63     
+ Misses       3547     3486      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool hack. But let's also open an issue about having selVector having size more than 2048. I think null mask need to change as well.

src/function/vector_hash_functions.cpp Show resolved Hide resolved
src/function/vector_hash_functions.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit c747899 into master Mar 27, 2024
17 checks passed
@acquamarin acquamarin deleted the hash-on-struct branch March 27, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants