Prepare Statement Improvement #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hououou
force-pushed
the
prepare_statement
branch
from
575e5f7
to
c08c334
Compare
andyfengHKU
requested changes
Mar 26, 2024
hououou
force-pushed
the
prepare_statement
branch
from
b3407f2
to
9e4b419
Compare
andyfengHKU
approved these changes
Mar 27, 2024
| @@ -323,6 +345,9 @@ std::unique_ptr<PreparedStatement> ClientContext::prepareNoLock( | |||
| } else { | |||
| preparedStatement->logicalPlans = std::move(plans); | |||
| } | |||
| if (transactionContext->isAutoTransaction() && requireNewTx) { | |||
| this->transactionContext->commit(); | |||
There was a problem hiding this comment.
shouldn't we have a similar check when rollback?
| if (!preparedStatement->isSuccess()) { | ||
| return queryResultWithError(preparedStatement->errMsg); | ||
| } | ||
| if (preparedStatement->preparedSummary.statementType != common::StatementType::TRANSACTION && | ||
| this->getTx() == nullptr) { | ||
| if (preparedStatement->parsedStatement->requireTx() && requiredNexTx && getTx() == nullptr) { |
There was a problem hiding this comment.
Can u branch out from this branch and try commit after prepare and we open a new transaction during execute. In this design, we should no longer need to pass requiredNexTx
hououou
force-pushed
the
prepare_statement
branch
from
e006d4c
to
21cd43c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3140 +/- ##
==========================================
- Coverage 92.08% 92.07% -0.01%
==========================================
Files 1168 1168
Lines 44065 44091 +26
==========================================
+ Hits 40577 40597 +20
- Misses 3488 3494 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3065
A little different implementation: for a query statement, we always need to prepare, and we will start a transaction.
prepare()is a standalone call. (requiredNewTx=true)prepare()called inquery(). Inquery(),execute()is always followed withprepare(), we will close the transaction inexecute(). (requiredNewTx=false)Similar logic is used in
execute().