Refactor aggregate functions #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.02%
==========================================
Files 1168 1168
Lines 44085 44062 -23
==========================================
- Hits 40538 40511 -27
- Misses 3547 3551 +4 ☔ View full report in Codecov by Sentry. |
acquamarin
requested review from
acquamarin
and removed request for
andyfengHKU
acquamarin
approved these changes
Mar 26, 2024
| @@ -106,6 +107,17 @@ struct CollectFunction { | |||
| std::make_unique<common::LogicalType>(arguments[0]->dataType)); | |||
| return std::make_unique<FunctionBindData>(std::move(returnType)); | |||
| } | |||
|
|
|||
| static function_set getFunctionSet() { | |||
| @@ -22,6 +23,14 @@ struct CountStarFunction : public BaseCountFunction { | |||
| (void)input; | |||
| state->count += multiplicity; | |||
| } | |||
|
|
|||
| static function_set getFunctionSet() { | |||
manh9203
force-pushed
the
aggregate-functions-refactor
branch
from
a4107b6
to
77a7d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue #3050