Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor path functions and RDF functions #3134

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

manh9203
Copy link
Contributor

This PR resolves the issue #3050
What is changed:

  • Refactor node/rel functions
  • Refactor path functions
  • Refactor RDF functions
  • Remove registerScalarFunctions

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 99.07407% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.96%. Comparing base (fc3b4a7) to head (ffb8f9c).

❗ Current head ffb8f9c differs from pull request most recent head dc946fb. Consider uploading reports for the commit dc946fb to get more accurate results

Files Patch % Lines
src/function/vector_path_functions.cpp 97.05% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3134   +/-   ##
=======================================
  Coverage   91.95%   91.96%           
=======================================
  Files        1171     1168    -3     
  Lines       44131    44083   -48     
=======================================
- Hits        40582    40539   -43     
+ Misses       3549     3544    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin requested review from acquamarin and removed request for andyfengHKU March 26, 2024 04:19
src/include/catalog/catalog_entry/catalog_entry_type.h Outdated Show resolved Hide resolved
src/function/vector_path_functions.cpp Outdated Show resolved Hide resolved
src/include/function/function_collection.h Show resolved Hide resolved
Refactor node/rel functions

Refactor path functions

Refactor rdf functions
@manh9203 manh9203 force-pushed the path-and-rdf-functions-refactor branch from ffb8f9c to dc946fb Compare March 26, 2024 20:47
@manh9203 manh9203 merged commit c1f68cd into master Mar 26, 2024
13 checks passed
@manh9203 manh9203 deleted the path-and-rdf-functions-refactor branch March 26, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants