Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progress for in_query_call operators #3120

Merged
merged 8 commits into from
Mar 28, 2024
Merged

Added progress for in_query_call operators #3120

merged 8 commits into from
Mar 28, 2024

Conversation

MSebanc
Copy link
Collaborator

@MSebanc MSebanc commented Mar 22, 2024

I have read and agree to the CLA of the Kuzu repository.

I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 97.02970% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 92.10%. Comparing base (9247fd2) to head (76a2ec6).
Report is 30 commits behind head on master.

Files Patch % Lines
src/common/task_system/progress_bar.cpp 75.00% 1 Missing ⚠️
...rator/persistent/reader/parquet/parquet_reader.cpp 96.29% 1 Missing ⚠️
tools/python_api/src_cpp/pyarrow/pyarrow_scan.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3120      +/-   ##
==========================================
+ Coverage   91.89%   92.10%   +0.20%     
==========================================
  Files        1169     1170       +1     
  Lines       43757    44257     +500     
==========================================
+ Hits        40211    40762     +551     
+ Misses       3546     3495      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I have read and agree to the CLA of the Kuzu repository.
@MSebanc MSebanc changed the title Added progress for csv and parquet in_query_call operator Added progress for in_query_call operator Mar 26, 2024
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the part for estimating progress of parallel csv and parquet is wrong. I believe you get the idea already so I don't need to take a look at this PR again.

Let me know if you need to discuss something.

@MSebanc MSebanc changed the title Added progress for in_query_call operator Added progress for in_query_call operators Mar 27, 2024
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
@MSebanc MSebanc marked this pull request as ready for review March 28, 2024 23:19
@MSebanc MSebanc merged commit 20e5cbb into master Mar 28, 2024
17 checks passed
@MSebanc MSebanc deleted the ProgressBarCsv branch March 28, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants