-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added progress for in_query_call operators #3120
Conversation
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3120 +/- ##
==========================================
+ Coverage 91.89% 92.10% +0.20%
==========================================
Files 1169 1170 +1
Lines 43757 44257 +500
==========================================
+ Hits 40211 40762 +551
+ Misses 3546 3495 -51 ☔ View full report in Codecov by Sentry. |
src/processor/operator/persistent/reader/csv/serial_csv_reader.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/reader/csv/parallel_csv_reader.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/reader/parquet/parquet_reader.cpp
Outdated
Show resolved
Hide resolved
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the part for estimating progress of parallel csv and parquet is wrong. I believe you get the idea already so I don't need to take a look at this PR again.
Let me know if you need to discuss something.
src/processor/operator/persistent/reader/csv/parallel_csv_reader.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/reader/csv/serial_csv_reader.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/reader/csv/parallel_csv_reader.cpp
Outdated
Show resolved
Hide resolved
src/processor/operator/persistent/reader/parquet/parquet_reader.cpp
Outdated
Show resolved
Hide resolved
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.