Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scalar function registration #3119

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

manh9203
Copy link
Collaborator

@manh9203 manh9203 commented Mar 22, 2024

This PR resolves the issue #3050
The changes are made on:

  • Comparison functions
  • Date functions
  • Timestamp functions
  • Interval functions
  • Blob functions
  • UUID functions
  • Struct functions
  • Map functions
  • Union functions

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 97.58065% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.91%. Comparing base (3813eed) to head (af53224).

Files Patch % Lines
src/function/vector_map_functions.cpp 95.83% 1 Missing ⚠️
src/function/vector_struct_functions.cpp 95.65% 1 Missing ⚠️
src/function/vector_union_functions.cpp 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3119      +/-   ##
==========================================
- Coverage   91.94%   91.91%   -0.03%     
==========================================
  Files        1171     1171              
  Lines       43989    43882     -107     
==========================================
- Hits        40444    40333     -111     
- Misses       3545     3549       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give the PR a better name?

@manh9203 manh9203 changed the title Refactor scalar functions on data types Refactor scalar function registration Mar 25, 2024
@manh9203 manh9203 force-pushed the types-functions-refactor branch 2 times, most recently from 140f6d0 to 984eab7 Compare March 25, 2024 15:34
Refactor comparison functions

Refactor date functions

Refactor timestamp functions

Refactor interval functions

Refactor blob functions

Refactor UUID functions

Refactor struct functions

Refactor map functions

Refactor union functions
@manh9203 manh9203 merged commit 53ef58e into master Mar 25, 2024
17 checks passed
@manh9203 manh9203 deleted the types-functions-refactor branch March 25, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants