Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryResult get_as_pl should always return a single chunk #3110

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

alexander-beedie
Copy link
Contributor

Small follow-up to #3084.

  • get_as_pl() should not offer a configurable chunk size, as Polars always wants a single chunk ;)
  • Slightly streamlined the adaptive "chunk_size" in get_as_arrow().
  • Integrated an explicit num_chunks assertion into the Arrow tests.

@alexander-beedie alexander-beedie changed the title Update get_as_pl (should always return a single chunk) QueryResult get_as_pl should always return a single chunk Mar 22, 2024
@ray6080 ray6080 requested a review from mewim March 22, 2024 06:24
Copy link
Member

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mewim mewim merged commit f9e1b12 into kuzudb:master Mar 22, 2024
12 of 15 checks passed
@alexander-beedie alexander-beedie deleted the polars-chunk-size branch March 22, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants