Cache DiskArray write header in-memory #3109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a bunch of tests failing.
Additionally, as far as I can tell, the
InMemDiskArray
isn't actually doing anything meaningful. operator[] is unused (except in theHashIndexBuilder
viaInMemDiskArrayBuilder
) and get/update are just using theBaseDiskArray
implementation. The description suggests that it's supposed to cache the entirety of the metadataDA in memory, but I don't think it's done that for a while (hence our attempts to cache metadata locally when updating columns).The cached header was creating some issues with the InMemDiskArray code, and while I think I was able to fix them in the initial version of this (or at least fix the crashes), being unused the code is not well tested. I've replaced InMemDiskArray with a thin shim for now, as it was doing some unnecessary work reading the pages into memory.