Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache DiskArray write header in-memory #3109

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

benjaminwinger
Copy link
Collaborator

@benjaminwinger benjaminwinger commented Mar 21, 2024

Still a bunch of tests failing.

Additionally, as far as I can tell, the InMemDiskArray isn't actually doing anything meaningful. operator[] is unused (except in the HashIndexBuilder via InMemDiskArrayBuilder) and get/update are just using the BaseDiskArray implementation. The description suggests that it's supposed to cache the entirety of the metadataDA in memory, but I don't think it's done that for a while (hence our attempts to cache metadata locally when updating columns).

The cached header was creating some issues with the InMemDiskArray code, and while I think I was able to fix them in the initial version of this (or at least fix the crashes), being unused the code is not well tested. I've replaced InMemDiskArray with a thin shim for now, as it was doing some unnecessary work reading the pages into memory.

@benjaminwinger benjaminwinger marked this pull request as ready for review March 25, 2024 21:30
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.95%. Comparing base (4d21128) to head (9e0e4f1).
Report is 3 commits behind head on master.

Files Patch % Lines
src/storage/storage_structure/disk_array.cpp 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3109      +/-   ##
==========================================
- Coverage   91.97%   91.95%   -0.03%     
==========================================
  Files        1171     1171              
  Lines       44041    44129      +88     
==========================================
+ Hits        40508    40580      +72     
- Misses       3533     3549      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/storage/store/var_list_column.cpp Show resolved Hide resolved
src/storage/store/node_table.cpp Outdated Show resolved Hide resolved
src/storage/storage_manager.cpp Show resolved Hide resolved
@benjaminwinger benjaminwinger merged commit a85f4fe into master Mar 26, 2024
17 checks passed
@benjaminwinger benjaminwinger deleted the disk-array-header branch March 26, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants