Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DUMMY_TRANSACTION #3106

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Replace DUMMY_TRANSACTION #3106

merged 1 commit into from
Mar 22, 2024

Conversation

hououou
Copy link
Collaborator

@hououou hououou commented Mar 21, 2024

Refer to #3062

Remove dummy transactions and propagate client context.

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.57143% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.89%. Comparing base (c3decc2) to head (a9f6f04).
Report is 35 commits behind head on master.

Files Patch % Lines
src/main/client_context.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   92.66%   91.89%   -0.78%     
==========================================
  Files        1157     1169      +12     
  Lines       43074    43743     +669     
==========================================
+ Hits        39916    40199     +283     
- Misses       3158     3544     +386

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hououou hououou changed the title Replace DUMMY_READ_TRANSACTION Replace DUMMY_TRANSACTION Mar 21, 2024
andyfengHKU
andyfengHKU reviewed Mar 21, 2024
View reviewed changes
src/binder/bind/bind_updating_clause.cpp Outdated Show resolved Hide resolved
src/include/binder/bound_statement_rewriter.h Show resolved Hide resolved
src/include/binder/query/query_graph_label_analyzer.h Show resolved Hide resolved
src/include/binder/rewriter/match_clause_pattern_label_rewriter.h Show resolved Hide resolved
src/include/planner/planner.h Show resolved Hide resolved
src/planner/plan/append_extend.cpp Outdated Show resolved Hide resolved
src/planner/plan/append_extend.cpp Outdated Show resolved Hide resolved
src/processor/map/map_delete.cpp Outdated Show resolved Hide resolved
src/processor/map/map_extend.cpp Outdated Show resolved Hide resolved
src/storage/stats/nodes_store_statistics.cpp Outdated Show resolved Hide resolved
ray6080
ray6080 reviewed Mar 22, 2024
View reviewed changes
src/storage/store/node_table.cpp Outdated Show resolved Hide resolved
src/storage/storage_manager.cpp Outdated Show resolved Hide resolved
@hououou hououou merged commit 7ec590a into master Mar 22, 2024
17 checks passed
@hououou hououou deleted the replace_dummy_transaction branch March 22, 2024 21:21
ray6080 pushed a commit that referenced this pull request Mar 23, 2024
@hououou @ray6080
remove dummy transactions (#3106)
8d6b5bc 
remove dummy transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 left review comments

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hououou @ray6080 @andyfengHKU