Refactor list functions #3100
Merged
Refactor list functions #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3100 +/- ##
==========================================
- Coverage 92.72% 92.62% -0.10%
==========================================
Files 1162 1161 -1
Lines 43148 43133 -15
==========================================
- Hits 40010 39953 -57
- Misses 3138 3180 +42 ☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Mar 20, 2024
| struct ListCreationFunction { | ||
| static constexpr const char* name = "LIST_CREATION"; | ||
|
|
||
| static function_set getFunctionSet(); | ||
| static std::unique_ptr<FunctionBindData> bindFunc( |
There was a problem hiding this comment.
You don't have to expose bindFunc, i would recommend defining them as static functions in cpp.
manh9203
force-pushed
the
list-functions-refactor
branch
from
27b588a
to
68c2856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue #3050