Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python List and Map Parameter Support #3090

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Python List and Map Parameter Support #3090

merged 2 commits into from
Mar 26, 2024

Conversation

mxwli
Copy link
Contributor

@mxwli mxwli commented Mar 19, 2024

Add support for #3054

NOTE: a lot of functions remain unavailable with nested parameter types. For example, we cannot currently bind functions like list_contains(a, b) if a is a parameter.

@mxwli mxwli requested review from andyfengHKU and acquamarin and removed request for andyfengHKU March 19, 2024 20:27
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 91.95%. Comparing base (3813eed) to head (a9f434e).
Report is 7 commits behind head on master.

❗ Current head a9f434e differs from pull request most recent head e702f29. Consider uploading reports for the commit e702f29 to get more accurate results

Files Patch % Lines
tools/python_api/src_cpp/py_connection.cpp 80.23% 17 Missing ⚠️
...der/bind_expression/bind_comparison_expression.cpp 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3090      +/-   ##
==========================================
+ Coverage   91.94%   91.95%   +0.01%     
==========================================
  Files        1171     1171              
  Lines       43989    44125     +136     
==========================================
+ Hits        40444    40577     +133     
- Misses       3545     3548       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed,we should implement a sniffing system and have a more mature implicit casting framework to handle such case.
Let's discuss after you have finished pyarrow stuff.

tools/python_api/src_cpp/py_connection.cpp Outdated Show resolved Hide resolved
tools/python_api/src_cpp/py_connection.cpp Show resolved Hide resolved
tools/python_api/src_cpp/py_connection.cpp Outdated Show resolved Hide resolved
tools/python_api/src_cpp/py_connection.cpp Show resolved Hide resolved
tools/python_api/src_cpp/py_connection.cpp Outdated Show resolved Hide resolved
tools/python_api/test/test_parameter.py Show resolved Hide resolved
@mxwli mxwli changed the title 3054 feature request Python List and Map Parameter Support Mar 26, 2024
clang-format and python lint

find lowest bitwidth

add requested changes

CI checks

add additional coverage

fix casting function

more coverage
@mxwli mxwli merged commit de72fc9 into master Mar 26, 2024
15 checks passed
@mxwli mxwli deleted the 3054-fix branch March 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] conn.execute(query, params) does not support parameters with list or dict values
2 participants