Hash index cleanup #3088
Merged
Hash index cleanup #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3088 +/- ##
==========================================
+ Coverage 92.66% 92.71% +0.04%
==========================================
Files 1157 1157
Lines 43074 43037 -37
==========================================
- Hits 39916 39901 -15
+ Misses 3158 3136 -22 ☔ View full report in Codecov by Sentry. |
benjaminwinger
force-pushed
the
hash-index-cleanup
branch
from
831ac08
to
5267f00
Compare
ray6080
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Make HashIndex use only one template parameter * Store key and value explicitly in hash index slots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of minor changes to the hash index. I've updated the HashIndex to use one template parameter like the HashIndexBuilder, and I've made SlotEntry store key/value instead of just a
databyte array. We can still use memcpy to copy both together, but it provides an easier to read way of accessing and updating the key and value.