Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed for progress bar to be configurable by CALL #3080

Merged
merged 9 commits into from
Mar 19, 2024
Merged

Allowed for progress bar to be configurable by CALL #3080

merged 9 commits into from
Mar 19, 2024

Conversation

MSebanc
Copy link
Collaborator

@MSebanc MSebanc commented Mar 18, 2024

I have read and agree to the CLA of the Kuzu repository.

@MSebanc
Allowed for progress bar to be configurable by CALL
874b14e 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Format fixes
72688bb 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Format fixes
7e1f361 
I have read and agree to the CLA of the Kuzu repository.
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.72%. Comparing base (e7c6d73) to head (3af97cf).
Report is 11 commits behind head on master.

❗ Current head 3af97cf differs from pull request most recent head 2c24371. Consider uploading reports for the commit 2c24371 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
- Coverage   92.94%   92.72%   -0.22%     
==========================================
  Files        1155     1157       +2     
  Lines       42919    43059     +140     
==========================================
+ Hits        39891    39928      +37     
- Misses       3028     3131     +103

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andyfengHKU
andyfengHKU approved these changes Mar 19, 2024
View reviewed changes
src/include/common/constants.h Outdated Show resolved Hide resolved
src/include/main/client_config.h Outdated Show resolved Hide resolved
src/include/main/settings.h Outdated Show resolved Hide resolved
src/include/main/client_context.h Outdated Show resolved Hide resolved
@MSebanc
Implemented feedback and fixed call bug
c443ae4 
I have read and agree to the CLA of the Kuzu repository.
andyfengHKU
andyfengHKU approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/task_system/progress_bar.cpp Show resolved Hide resolved
src/common/task_system/progress_bar.cpp Show resolved Hide resolved
@MSebanc
Removed unused header and implemented feedback
f0c76fd
@MSebanc
Minor changes
10d4ff2 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Format changes
5566332 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Format changes
3af97cf 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Implemented feedback
2c24371 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc MSebanc marked this pull request as ready for review March 19, 2024 19:48
@MSebanc MSebanc merged commit 0ced885 into master Mar 19, 2024
12 of 13 checks passed
@MSebanc MSebanc deleted the Progress-Bar-Updates branch March 19, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MSebanc @andyfengHKU