Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the registration of arithmetic functions #3079

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

manh9203
Copy link
Contributor

This PR resolves the issue #3050

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 98.93048% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.64%. Comparing base (8b2c768) to head (efdc1e4).

Files Patch % Lines
src/function/vector_arithmetic_functions.cpp 98.82% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3079      +/-   ##
==========================================
- Coverage   92.65%   92.64%   -0.01%     
==========================================
  Files        1157     1157              
  Lines       43086    43041      -45     
==========================================
- Hits        39921    39876      -45     
  Misses       3165     3165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manh9203 manh9203 force-pushed the arithmetic-functions-refactor branch from 039513e to efdc1e4 Compare March 19, 2024 18:31
@manh9203 manh9203 merged commit 8fa40d6 into master Mar 19, 2024
17 checks passed
@manh9203 manh9203 deleted the arithmetic-functions-refactor branch March 19, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants