Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table states #3072

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Table states #3072

merged 1 commit into from
Mar 25, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Mar 18, 2024

Mainly abstract several states for operations on tables, including read, insert, update, and delete. Mostly to simplify interfaces and also track operation states with possible caches of csr info, like RelDataReadState, and chunk metadata, references to local storage chunks, etc.
This is the first of a series of PRs to properly unify operations on tables over states.

Additional changes: Passed in ClientContext into Transaction.

@ray6080 ray6080 force-pushed the refactor-local-storage branch 2 times, most recently from 7b06385 to 775d2e6 Compare March 19, 2024 04:21
Base automatically changed from refactor-local-storage to master March 19, 2024 05:46
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 96.96203% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 91.97%. Comparing base (53ef58e) to head (68ad30f).
Report is 2 commits behind head on master.

Files Patch % Lines
src/storage/local_storage/local_rel_table.cpp 95.55% 2 Missing ⚠️
src/storage/local_storage/local_storage.cpp 90.00% 2 Missing ⚠️
...c/include/storage/local_storage/local_node_table.h 80.00% 1 Missing ⚠️
...rc/include/storage/local_storage/local_rel_table.h 85.71% 1 Missing ⚠️
src/include/storage/local_storage/local_table.h 50.00% 1 Missing ⚠️
src/include/storage/store/rel_table.h 94.11% 1 Missing ⚠️
src/storage/store/node_table.cpp 98.61% 1 Missing ⚠️
src/storage/store/rel_table.cpp 96.15% 1 Missing ⚠️
src/storage/store/rel_table_data.cpp 96.42% 1 Missing ⚠️
src/storage/wal_replayer.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
+ Coverage   91.91%   91.97%   +0.06%     
==========================================
  Files        1171     1171              
  Lines       43882    44027     +145     
==========================================
+ Hits        40332    40495     +163     
+ Misses       3550     3532      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 force-pushed the table-states branch 2 times, most recently from 7cc8275 to 496a661 Compare March 20, 2024 05:22
@ray6080 ray6080 merged commit a8b15dc into master Mar 25, 2024
17 checks passed
@ray6080 ray6080 deleted the table-states branch March 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants