Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement catalog cache in postgres scanner #3071

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

acquamarin
Copy link
Collaborator

This PR improves the duckdb scan binding performance by caching table info of each duckdb table.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 57.69231% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 93.01%. Comparing base (a0ee10e) to head (cc93226).
Report is 5 commits behind head on master.

Files Patch % Lines
src/include/binder/ddl/bound_create_table_info.h 59.09% 9 Missing ⚠️
src/main/database_manager.cpp 0.00% 5 Missing ⚠️
src/binder/bind/bind_reading_clause.cpp 0.00% 4 Missing ⚠️
src/include/storage/storage_extension.h 0.00% 2 Missing ⚠️
...nclude/catalog/catalog_entry/table_catalog_entry.h 50.00% 1 Missing ⚠️
src/processor/operator/attach_database.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3071      +/-   ##
==========================================
- Coverage   93.04%   93.01%   -0.04%     
==========================================
  Files        1155     1155              
  Lines       43266    43286      +20     
==========================================
+ Hits        40256    40261       +5     
- Misses       3010     3025      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/main/database_manager.cpp Outdated Show resolved Hide resolved
src/include/common/types/ku_string.h Outdated Show resolved Hide resolved
extension/duckdb_scanner/src/duckdb_storage.cpp Outdated Show resolved Hide resolved
extension/duckdb_scanner/src/duckdb_storage.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit bd963c1 into master Mar 18, 2024
16 of 17 checks passed
@acquamarin acquamarin deleted the catalog-cache branch March 18, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants