fix IMPORT_DATABASE path #3063
Merged
fix IMPORT_DATABASE path #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3063 +/- ##
=======================================
Coverage 91.89% 91.90%
=======================================
Files 1169 1169
Lines 43759 43764 +5
=======================================
+ Hits 40214 40220 +6
+ Misses 3545 3544 -1 ☔ View full report in Codecov by Sentry. |
hououou
force-pushed
the
import_path_fix
branch
from
aedf08c
to
048ad70
Compare
andyfengHKU
requested changes
Mar 15, 2024
acquamarin
reviewed
Mar 16, 2024
hououou
force-pushed
the
import_path_fix
branch
3 times, most recently
from
02f8798
to
5bd546e
Compare
acquamarin
approved these changes
Mar 21, 2024
hououou
force-pushed
the
import_path_fix
branch
from
0a27ac7
to
9678007
Compare
hououou
force-pushed
the
import_path_fix
branch
from
d11219b
to
73949ed
Compare
andyfengHKU
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we execute the export database statement
"export database 'path1' ", we will export data in a directory'path1', along with csv cyphers, data cyphers, and macro cyphers for import database later. The copy statement is just likecopy xx from path1/tablename. Assume we move this exported data directory to other directories, or to other platforms, and then want to import it withimport database 'path2'.Then the path1 in copy statement is not correct. This PR is to replace the path in copy statements with path2, i.e., the bounded import file path.