Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rel csr sliding out-of-place commit and null strings #3055

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Mar 14, 2024

  1. Inside distributeAndUpdateColumn, set new chunk to all null before copy existing values and inserting new ones.
  2. Fix Column::commitColumnChunkOutOfPlace.
  3. Skip null strings in StringColumn::canCommitInPlace.

@ray6080 ray6080 changed the title Fix rel insert bug Fix rel csr sliding out-of-place commit and null strings Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.27%. Comparing base (ff186a5) to head (0b7adb9).

Files Patch % Lines
src/storage/store/column_chunk.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
+ Coverage   93.25%   93.27%   +0.01%     
==========================================
  Files        1133     1133              
  Lines       43117    43123       +6     
==========================================
+ Hits        40209    40221      +12     
+ Misses       2908     2902       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit f8efa2a into master Mar 14, 2024
17 checks passed
@ray6080 ray6080 deleted the fix-rel-insert-bug branch March 14, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants