-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Progress Bar #3051
Implemented Progress Bar #3051
Conversation
I have read and agree to the CLA of the Kuzu repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that I didn't pick up from this draft is that at what frequency are we printing the progress bar. Maybe let's discuss that.
I have read and agree to the CLA of the Kuzu repository
I have read and agree to the CLA of the Kuzu repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't need to see this PR again. Just make sure you cleaned up the code and don't forget to leave some comment under ProgressBar.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the kuzu repository
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3051 +/- ##
==========================================
- Coverage 92.94% 92.88% -0.07%
==========================================
Files 1155 1157 +2
Lines 42919 42978 +59
==========================================
+ Hits 39891 39919 +28
- Misses 3028 3059 +31 ☔ View full report in Codecov by Sentry. |
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.
I have read and agree to the CLA of the Kuzu repository.