Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First-pass lint/format for Python shell tests #3034

Merged
merged 1 commit into from
Mar 13, 2024
Merged

First-pass lint/format for Python shell tests #3034

merged 1 commit into from
Mar 13, 2024

Conversation

alexander-beedie
Copy link
Contributor

Along the same lines as #3023.

  • Applies formatting and a subset of the lint rules (a follow-up can handle the remaining lint).
  • Does not apply any function signature or return typing yet.

@ray6080 ray6080 requested a review from mewim March 13, 2024 02:18
@mewim mewim requested a review from MSebanc March 13, 2024 03:05
@mewim
Copy link
Member

mewim commented Mar 13, 2024 •
edited
Loading

@MSebanc could you please review this as you wrote the shell tests?

MSebanc
MSebanc approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@MSebanc MSebanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@MSebanc MSebanc merged commit 7110f91 into kuzudb:master Mar 13, 2024
11 of 14 checks passed
@alexander-beedie alexander-beedie deleted the shell-tests-lint-format branch March 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSebanc MSebanc MSebanc approved these changes

@mewim mewim Awaiting requested review from mewim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-beedie @mewim @MSebanc