Replace ValueVector with ColumnChunk in LocalStorage #3028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the use of
ValueVector
withColumnChunk
insideLocalStorage
.Side effects:
void lookup(common::offset_t offsetInChunk, common::ValueVector& output, common::sel_t posInOutputVector)
.scan
will come later.MemoryManager
into LocalStorage.Additionally:
NodeGroup
toChunkedNodeGroup
. The motivation is to differentiate the logic concept and physical data structure. "node group" is a logical concept, while "ChunkedNodeGroup" is a physical data structure that organizes data in columnar way in the same layout as they are on disk (for uncompressed). the class nameNodeGroup
can be confusing sometimes when it actually doesn't contain all tuples in a node group, but only partial of it.