Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ValueVector with ColumnChunk in LocalStorage #3028

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Mar 12, 2024

Replaced the use of ValueVector with ColumnChunk inside LocalStorage.

Side effects:

  • add lookup interface to ColumnChunks. void lookup(common::offset_t offsetInChunk, common::ValueVector& output, common::sel_t posInOutputVector). scan will come later.
  • no longer pass MemoryManager into LocalStorage.

Additionally:

  • renamed NodeGroup to ChunkedNodeGroup. The motivation is to differentiate the logic concept and physical data structure. "node group" is a logical concept, while "ChunkedNodeGroup" is a physical data structure that organizes data in columnar way in the same layout as they are on disk (for uncompressed). the class name NodeGroup can be confusing sometimes when it actually doesn't contain all tuples in a node group, but only partial of it.
  • fixed the storage of rel tableID in local storage. also fixed ground truth in test files.
  • removed a test file (wasn't intended to add to run in CI) I accidentally committed previously.

@ray6080 ray6080 force-pushed the multi-copy-rel-s1 branch 2 times, most recently from fa6d52c to 1f88b3f Compare March 14, 2024 09:46
Base automatically changed from multi-copy-rel-s1 to master March 14, 2024 11:20
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 87.69231% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 92.66%. Comparing base (e7c6d73) to head (775d2e6).
Report is 1 commits behind head on master.

Files Patch % Lines
src/storage/store/var_list_column_chunk.cpp 8.33% 11 Missing ⚠️
src/storage/store/column_chunk.cpp 75.60% 10 Missing ⚠️
src/storage/store/node_group.cpp 80.00% 6 Missing ⚠️
src/include/storage/store/node_group.h 88.88% 2 Missing ⚠️
src/include/storage/store/var_list_column_chunk.h 0.00% 1 Missing ⚠️
src/storage/local_storage/local_rel_table.cpp 75.00% 1 Missing ⚠️
src/storage/store/string_column_chunk.cpp 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3028      +/-   ##
==========================================
- Coverage   92.94%   92.66%   -0.29%     
==========================================
  Files        1155     1157       +2     
  Lines       42919    43055     +136     
==========================================
+ Hits        39891    39895       +4     
- Misses       3028     3160     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 removed the request for review from benjaminwinger March 14, 2024 12:45
@ray6080 ray6080 force-pushed the refactor-local-storage branch 3 times, most recently from 841dde6 to 7b06385 Compare March 18, 2024 07:18
src/storage/store/node_group.cpp Outdated Show resolved Hide resolved
@ray6080 ray6080 merged commit 8854ebd into master Mar 19, 2024
17 checks passed
@ray6080 ray6080 deleted the refactor-local-storage branch March 19, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants