Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import cache fix and revert revert #3025

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

mxwli
Copy link
Collaborator

@mxwli mxwli commented Mar 11, 2024

Apply import cache fix and revert the initial revert in two separate commits.

It seems that no additional py::module::import calls have been made since the initial revert, so no additional import cache calls are needed.

@mxwli mxwli requested a review from acquamarin March 11, 2024 15:59
Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check we have replaced every import statemen with import cache

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 97.18310% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.26%. Comparing base (f4a95ab) to head (3f84585).

Files Patch % Lines
...api/src_cpp/include/cached_import/py_cached_item.h 50.00% 1 Missing ⚠️
.../src_cpp/include/cached_import/py_cached_modules.h 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3025   +/-   ##
=======================================
  Coverage   93.25%   93.26%           
=======================================
  Files        1125     1130    +5     
  Lines       42956    43000   +44     
=======================================
+ Hits        40059    40104   +45     
+ Misses       2897     2896    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxwli mxwli merged commit 8642ccb into master Mar 11, 2024
15 checks passed
@mxwli mxwli deleted the import-cache-fix-and-revert-revert branch March 11, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants