Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework VAR_LIST #3019

Closed
wants to merge 1 commit into from
Closed

Rework VAR_LIST #3019

wants to merge 1 commit into from

Conversation

hououou
Copy link
Collaborator

@hououou hououou commented Mar 11, 2024

addtionally store length to var list

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 98.09524% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.28%. Comparing base (8642ccb) to head (efcce5c).

Files Patch % Lines
src/storage/store/var_list_column.cpp 98.11% 1 Missing ⚠️
src/storage/store/var_list_column_chunk.cpp 96.96% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3019   +/-   ##
=======================================
  Coverage   93.28%   93.28%           
=======================================
  Files        1130     1130           
  Lines       42962    43029   +67     
=======================================
+ Hits        40076    40140   +64     
- Misses       2886     2889    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/include/storage/store/var_list_column_chunk.h Outdated Show resolved Hide resolved
src/storage/store/var_list_column.cpp Outdated Show resolved Hide resolved
src/include/storage/store/var_list_column_chunk.h Outdated Show resolved Hide resolved
src/include/storage/store/var_list_column_chunk.h Outdated Show resolved Hide resolved
src/include/storage/store/var_list_column.h Outdated Show resolved Hide resolved
src/include/storage/store/var_list_column.h Outdated Show resolved Hide resolved
src/storage/store/var_list_column.cpp Outdated Show resolved Hide resolved
src/storage/store/var_list_column.cpp Outdated Show resolved Hide resolved
@ray6080
Copy link
Contributor

ray6080 commented Mar 23, 2024

See #3093.

@ray6080 ray6080 closed this Mar 23, 2024
@hououou hououou deleted the rework_var_list branch April 8, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants