Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine append(ValueVector) with appendOne #3017

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Mar 10, 2024

Combine following two interfaces in ColumnChunk

    virtual void append(common::ValueVector* vector);
    virtual void appendOne(common::ValueVector* vector, common::vector_idx_t pos);

into

    virtual void append(common::ValueVector* vector, common::SelectionVector& selVector);

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.27%. Comparing base (dc9771f) to head (c149349).

Files Patch % Lines
src/storage/store/column_chunk.cpp 75.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3017      +/-   ##
==========================================
- Coverage   93.27%   93.27%   -0.01%     
==========================================
  Files        1125     1125              
  Lines       42952    42914      -38     
==========================================
- Hits        40063    40027      -36     
+ Misses       2889     2887       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 67e9204 into master Mar 11, 2024
15 checks passed
@ray6080 ray6080 deleted the remove-append-one branch March 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants