Pass client context to binder #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
force-pushed
the
pass-client-context-binder
branch
from
96cd9b3
to
21b9170
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3015 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 1124 1124
Lines 42934 42953 +19
=======================================
+ Hits 40041 40062 +21
+ Misses 2893 2891 -2 ☔ View full report in Codecov by Sentry. |
andyfengHKU
force-pushed
the
pass-client-context-binder
branch
2 times, most recently
from
87ea276
to
170a81a
Compare
andyfengHKU
force-pushed
the
pass-client-context-binder
branch
from
170a81a
to
a3a6c2a
Compare
acquamarin
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor PR to avoid passing individual database components into binder, e.g. BM, MM, etc.... Instead, we pass client context only because client context already contains all database components.