Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract client config #3010

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Abstract client config #3010

merged 1 commit into from
Mar 8, 2024

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.30%. Comparing base (5e598ec) to head (b2f50ac).

Files Patch % Lines
src/main/client_context.cpp 90.00% 3 Missing ⚠️
src/include/main/settings.h 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3010      +/-   ##
==========================================
- Coverage   93.31%   93.30%   -0.01%     
==========================================
  Files        1124     1124              
  Lines       42912    42912              
==========================================
- Hits        40042    40041       -1     
- Misses       2870     2871       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit c554a20 into master Mar 8, 2024
15 checks passed
@andyfengHKU andyfengHKU deleted the add-client-config branch March 8, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants