Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple COPY statements on rel tables #2989

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Mar 3, 2024

Experimental feature for now. This can be enabled by CALL setting.

call enable_multi_copy=true;

There is a temp hack for setting rel offset in PlanMapper::mapCopyRelFrom. Details can be found in #3033.

@ray6080 ray6080 force-pushed the multi-copy-rel-s1 branch 3 times, most recently from 9d28689 to 6a3177e Compare March 4, 2024 07:13
@ray6080 ray6080 force-pushed the multi-copy-rel-s1 branch 5 times, most recently from 189e842 to 34022e9 Compare March 12, 2024 03:13
@ray6080 ray6080 force-pushed the multi-copy-rel-s1 branch 2 times, most recently from fa6d52c to 1f88b3f Compare March 14, 2024 09:46
Base automatically changed from multi-copy-rel-s1 to master March 14, 2024 11:20
@ray6080 ray6080 marked this pull request as ready for review March 25, 2024 07:47
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 92.00%. Comparing base (3813eed) to head (02d1aef).

Files Patch % Lines
src/include/main/settings.h 66.66% 2 Missing ⚠️
src/common/data_chunk/data_chunk_collection.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
+ Coverage   91.94%   92.00%   +0.06%     
==========================================
  Files        1171     1171              
  Lines       43989    44065      +76     
==========================================
+ Hits        40444    40541      +97     
+ Misses       3545     3524      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjaminwinger benjaminwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@ray6080 ray6080 merged commit b208d15 into master Mar 25, 2024
17 checks passed
@ray6080 ray6080 deleted the multi-copy-rel-s2 branch March 25, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants