Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder extension tests for CI pipeline #2987

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented Mar 3, 2024

The extension tests in current CI pipeline uses a secret that external contributors have no access to, which causes the tests to fail and blocks the rest of the pipeline from running. In this PR the extension tests are moved as a last step in each pipeline to ensure that the rest of the pipeline still runs.

@mewim mewim requested a review from acquamarin March 3, 2024 15:17
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (add8473) to head (4fbeb1a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2987   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files        1156     1156           
  Lines       43965    43965           
=======================================
+ Hits        40533    40535    +2     
+ Misses       3432     3430    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim closed this Apr 2, 2024
@mewim mewim reopened this Apr 2, 2024
@mewim mewim merged commit 94fd5eb into master Apr 2, 2024
20 checks passed
@mewim mewim deleted the reorder-extension-tests branch April 2, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants