Refactor: separate insertions and updates in rel table local storage #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
force-pushed
the
multi-copy-rel-s1
branch
from
dac8b8d
to
26bfbe3
Compare
ray6080
changed the title
ray6080
force-pushed
the
multi-copy-rel
branch
3 times, most recently
from
d2bd0b0
to
ca5d82a
Compare
ray6080
force-pushed
the
multi-copy-rel-s1
branch
from
26bfbe3
to
161e759
Compare
ray6080
force-pushed
the
multi-copy-rel-s1
branch
from
161e759
to
30ced06
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2982 +/- ##
==========================================
+ Coverage 93.27% 93.36% +0.08%
==========================================
Files 1133 1133
Lines 43123 43060 -63
==========================================
- Hits 40222 40201 -21
+ Misses 2901 2859 -42 ☔ View full report in Codecov by Sentry. |
ray6080
force-pushed
the
multi-copy-rel-s1
branch
5 times, most recently
from
2fa3389
to
b12ab78
Compare
ray6080
force-pushed
the
multi-copy-rel-s1
branch
from
b12ab78
to
189e842
Compare
ray6080
force-pushed
the
multi-copy-rel-s1
branch
from
189e842
to
34022e9
Compare
benjaminwinger
approved these changes
Mar 13, 2024
| const offset_set_t& deleteInfo) override { | ||
| // Avoid unused parameter warnings. | ||
| (void)updateInfo; | ||
| (void)deleteInfo; |
There was a problem hiding this comment.
You can comment out the parameter names instead
There was a problem hiding this comment.
I still want to do assertions over them. that's why I kept these parameters, but they keep throwing warnings during release build. Might be better ways to handle these?
ray6080
force-pushed
the
multi-copy-rel-s1
branch
from
34022e9
to
fa6d52c
Compare
ray6080
force-pushed
the
multi-copy-rel-s1
branch
from
fa6d52c
to
1f88b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the middle of reworking local storage. This PR is mainly separating the storage of insertions and updates in local storage.
LocalDataChunkCollection insertChunks; LocalDeletionInfo deleteInfo; std::vector<LocalDataChunkCollection> updateChunks;Note that the following PR will replace the use of DataChunk with a vector of ColumnChunks.
This PR is becoming a bit messy as I did some other refactoring alongside:
unique_ptruse ofLogicalTypeandDataChunk.NOTE: This PR breaks storage compatibility as it changes the layout of statistics.