Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functions for casting string to var-list #2970

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

manh9203
Copy link
Contributor

This pull request resolves issue #2755, which concerns the functionality for casting strings to variable lists. Here are the key updates:

  • Leading spaces are now trimmed before the casting process to address the issue.
  • Regarding the handling of single quotes, I conducted tests with DuckDB and found that they also interpret quotes as part of the string, so I retained them in the implementation.
  • I attempted to implement escape character in this section, but encountered challenges with formatting the input string. I would need further discussion if we intend to pursue this feature at this time.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (e76c6ea) to head (797ee72).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2970   +/-   ##
=======================================
  Coverage   93.52%   93.53%           
=======================================
  Files        1119     1119           
  Lines       42991    42991           
=======================================
+ Hits        40209    40211    +2     
+ Misses       2782     2780    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manh9203 manh9203 linked an issue Feb 29, 2024 that may be closed by this pull request
@manh9203 manh9203 merged commit c1dc44a into master Feb 29, 2024
15 checks passed
@manh9203 manh9203 deleted the cast-string-to-varlist branch February 29, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour when inserting/copying a list of string.
2 participants