Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: unify CopyNode and CopyRel operator #2955

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Feb 27, 2024

  • Unify common info/state/functions in CopyNode and CopyRel into a base class.
  • Rename Copy to BatchInsert.

@ray6080 ray6080 force-pushed the refactor-many-one-table branch 2 times, most recently from 063ed1e to 9a2ee9e Compare March 3, 2024 15:01
Base automatically changed from refactor-many-one-table to master March 3, 2024 16:59
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 96.18321% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 93.31%. Comparing base (f9e9e29) to head (ca5d82a).

Files Patch % Lines
.../processor/operator/persistent/node_batch_insert.h 93.10% 2 Missing ⚠️
...e/processor/operator/persistent/rel_batch_insert.h 88.88% 2 Missing ⚠️
src/processor/operator/index_lookup.cpp 75.00% 2 Missing ⚠️
...processor/operator/persistent/rel_batch_insert.cpp 95.12% 2 Missing ⚠️
...clude/processor/operator/persistent/batch_insert.h 92.30% 1 Missing ⚠️
src/include/storage/wal/wal_record.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2955   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files        1121     1123    +2     
  Lines       42863    42887   +24     
=======================================
+ Hits        39996    40022   +26     
+ Misses       2867     2865    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 04c554b into master Mar 3, 2024
15 checks passed
@ray6080 ray6080 deleted the multi-copy-rel branch March 3, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants