Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move apis from connection to clientcontext #2951

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

hououou
Copy link
Collaborator

@hououou hououou commented Feb 26, 2024

No description provided.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 93.96985% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 93.50%. Comparing base (d2cfc65) to head (29f2534).
Report is 1 commits behind head on master.

Files Patch % Lines
src/main/client_context.cpp 95.48% 8 Missing ⚠️
src/main/connection.cpp 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
- Coverage   93.51%   93.50%   -0.02%     
==========================================
  Files        1121     1121              
  Lines       42913    42950      +37     
==========================================
+ Hits        40131    40161      +30     
- Misses       2782     2789       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hououou hououou merged commit 885e115 into master Feb 28, 2024
15 checks passed
@hououou hououou deleted the apis_to_client_context branch February 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants