Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve functionality of CString-to-Interval parser #2932

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

manh9203
Copy link
Contributor

This pull request addressed problem #2882 by modifying the way time is imported within Intervals. The problem is because the time is exported in the format of hh:mm:ss, which the parser couldn't handle during import. The modifications include adapting Interval::fromCString to accommodate this format. Additionally, the updated parser now supports new date specifiers such as millennium, century, decade, quarter and week, along with partial numbers for time values.

@manh9203 manh9203 linked an issue Feb 22, 2024 that may be closed by this pull request
@manh9203 manh9203 assigned manh9203 and unassigned manh9203 Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.50%. Comparing base (93fc6e2) to head (0343c26).
Report is 8 commits behind head on master.

❗ Current head 0343c26 differs from pull request most recent head 7d0b028. Consider uploading reports for the commit 7d0b028 to get more accurate results

Files Patch % Lines
src/common/types/interval_t.cpp 98.31% 2 Missing ⚠️
src/common/types/dtime_t.cpp 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2932      +/-   ##
==========================================
+ Coverage   93.48%   93.50%   +0.01%     
==========================================
  Files        1116     1121       +5     
  Lines       42717    42859     +142     
==========================================
+ Hits        39936    40074     +138     
- Misses       2781     2785       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/common/types/interval_t.cpp Outdated Show resolved Hide resolved
src/common/types/interval_t.cpp Outdated Show resolved Hide resolved
src/common/types/interval_t.cpp Outdated Show resolved Hide resolved
src/common/types/interval_t.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@acquamarin acquamarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder: please squash all your commits before merging

@manh9203
Copy link
Contributor Author

I just made the changes, do you need to review again before we merge?

@manh9203 manh9203 merged commit 7b174bf into master Feb 23, 2024
17 of 20 checks passed
@manh9203 manh9203 deleted the interval-parser-from-cstring branch February 23, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CopyTo and CopyFrom do not align with interval datatype
2 participants