-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve functionality of CString-to-Interval parser #2932
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2932 +/- ##
==========================================
+ Coverage 93.48% 93.50% +0.01%
==========================================
Files 1116 1121 +5
Lines 42717 42859 +142
==========================================
+ Hits 39936 40074 +138
- Misses 2781 2785 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder: please squash all your commits before merging
5c10841
to
0343c26
Compare
I just made the changes, do you need to review again before we merge? |
0343c26
to
7d0b028
Compare
This pull request addressed problem #2882 by modifying the way time is imported within Intervals. The problem is because the time is exported in the format of
hh:mm:ss
, which the parser couldn't handle during import. The modifications include adaptingInterval::fromCString
to accommodate this format. Additionally, the updated parser now supports new date specifiers such asmillennium
,century
,decade
,quarter
andweek
, along with partial numbers for time values.