Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: copy var lists and strings #2928

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Patch: copy var lists and strings #2928

merged 1 commit into from
Feb 22, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Feb 22, 2024

Two fixes:

  • indices column chunk is not initialized with correct capacity;
  • ColumnChunks are reused during copy rel, but we didn't reset column chunk's buffer during resetToEmpty. Now we leave gaps in rel csr arrays, and gapped values will be filled with old data from previous "chunks", and this can corrupt finalize for strings. (index can be insane values, leading to out-of-bound read from dictionary chunk).

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b61758e) 93.49% compared to head (4ee6ed3) 93.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2928   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files        1116     1116           
  Lines       42716    42717    +1     
=======================================
+ Hits        39936    39938    +2     
+ Misses       2780     2779    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 5f7ab4e into master Feb 22, 2024
15 checks passed
@ray6080 ray6080 deleted the fix-var-list-string branch February 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants