Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ftable scan as a function #2921

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Refactor ftable scan as a function #2921

merged 1 commit into from
Feb 22, 2024

Conversation

andyfengHKU
Copy link
Contributor

This PR removes FactorizedTableScan operator and instead make it a scan function executed by InQueryCall operator.

Additionally this PR moves several functions from its header file to corresponding cpp file.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fb860a6) 93.45% compared to head (4d0d68d) 93.49%.
Report is 9 commits behind head on master.

Files Patch % Lines
...ator/persistent/reader/csv/parallel_csv_reader.cpp 84.21% 3 Missing ⚠️
src/processor/operator/call/in_query_call.cpp 96.42% 1 Missing ⚠️
...erator/persistent/reader/csv/serial_csv_reader.cpp 97.29% 1 Missing ⚠️
...essor/operator/table_scan/ftable_scan_function.cpp 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2921      +/-   ##
==========================================
+ Coverage   93.45%   93.49%   +0.03%     
==========================================
  Files        1117     1115       -2     
  Lines       42687    42694       +7     
==========================================
+ Hits        39895    39918      +23     
+ Misses       2792     2776      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/function/table/call/current_setting.cpp Show resolved Hide resolved
src/function/table/call/show_connection.cpp Show resolved Hide resolved
src/include/processor/operator/call/in_query_call.h Outdated Show resolved Hide resolved
src/include/processor/operator/call/in_query_call.h Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the ftable-scan-to-scan branch 2 times, most recently from a58c01f to d219a22 Compare February 22, 2024 02:32
@andyfengHKU andyfengHKU merged commit 44db18a into master Feb 22, 2024
15 checks passed
@andyfengHKU andyfengHKU deleted the ftable-scan-to-scan branch February 22, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants