Fix reading strings from the hash index overflow file #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is multi-threaded contention, data was being appended to the result multiple times because of how optimisticRead behaves. Replacing the relevant portion of the string instead of appending makes sure that the result is correct and overwrites the null data from previous runs when the optimisticRead finally manages a successful read. Fixes #2916
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2918 +/- ##
==========================================
- Coverage 93.47% 93.46% -0.01%
==========================================
Files 1117 1117
Lines 42739 42740 +1
==========================================
- Hits 39951 39949 -2
- Misses 2788 2791 +3 ☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is multi-threaded contention, data was being appended to the result multiple times because of how optimisticRead behaves.
Replacing the relevant portion of the string instead of appending makes sure that the result is correct and overwrites the null data from previous runs when the optimisticRead finally manages a successful read.
Fixes #2916