Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table call function #2915

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Refactor table call function #2915

merged 1 commit into from
Feb 20, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Feb 20, 2024

  • Split call functions into their own files
  • Avoid passing mm and sm in table function bind data. Instead we always pass client context.

src/function/table/call/current_setting.cpp Outdated Show resolved Hide resolved
src/function/table/call/current_setting.cpp Outdated Show resolved Hide resolved
src/function/table/call/CMakeLists.txt Outdated Show resolved Hide resolved
src/include/function/table_functions.h Show resolved Hide resolved
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (876da07) 93.46% compared to head (338c5cc) 93.46%.

Files Patch % Lines
src/function/table/call/storage_info.cpp 95.07% 7 Missing ⚠️
src/function/table/call/current_setting.cpp 93.10% 2 Missing ⚠️
src/function/table/call/show_connection.cpp 96.77% 2 Missing ⚠️
src/function/table/call/db_version.cpp 94.73% 1 Missing ⚠️
src/function/table/call/show_tables.cpp 97.36% 1 Missing ⚠️
src/function/table/call/table_info.cpp 98.21% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2915      +/-   ##
==========================================
- Coverage   93.46%   93.46%   -0.01%     
==========================================
  Files        1111     1117       +6     
  Lines       42729    42739      +10     
==========================================
+ Hits        39938    39946       +8     
- Misses       2791     2793       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 1416881 into master Feb 20, 2024
15 checks passed
@andyfengHKU andyfengHKU deleted the refactor-table-func branch February 20, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants