Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement function catalog-entry #2910

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Implement function catalog-entry #2910

merged 1 commit into from
Feb 19, 2024

Conversation

acquamarin
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (0d57b0b) 93.45% compared to head (b8aa918) 93.47%.
Report is 4 commits behind head on master.

Files Patch % Lines
src/function/built_in_function_utils.cpp 96.53% 23 Missing ⚠️
...c/catalog/catalog_entry/function_catalog_entry.cpp 50.00% 3 Missing ⚠️
...talog/catalog_entry/scalar_macro_catalog_entry.cpp 81.25% 3 Missing ⚠️
...alog/catalog_entry/scalar_function_catalog_entry.h 0.00% 1 Missing ⚠️
...catalog/catalog_entry/scalar_macro_catalog_entry.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2910      +/-   ##
==========================================
+ Coverage   93.45%   93.47%   +0.02%     
==========================================
  Files        1104     1111       +7     
  Lines       42468    42729     +261     
==========================================
+ Hits        39687    39941     +254     
- Misses       2781     2788       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Double check some coverage issues.

@acquamarin acquamarin merged commit 876da07 into master Feb 19, 2024
15 checks passed
@acquamarin acquamarin deleted the function-catalog-entry branch February 19, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants